-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: allow setting mount device for bpffs #2338
Conversation
Master branch: ecf45e6 |
Master branch: f60edf5 |
e3c1b2e
to
2c213be
Compare
Master branch: 5b3d729 |
2c213be
to
47720d5
Compare
Master branch: b645941 |
47720d5
to
3d0825f
Compare
Master branch: 3ccdcee |
3d0825f
to
34a551e
Compare
Master branch: 1705c62 |
34a551e
to
a9ba5a8
Compare
Master branch: 35580f9 |
a9ba5a8
to
08b8429
Compare
Master branch: 35580f9 |
08b8429
to
b97b730
Compare
Master branch: 63d000c |
b97b730
to
b59f387
Compare
Master branch: 11f9983 |
b59f387
to
130721c
Compare
11f9983
to
9e6b19a
Compare
Master branch: 9e6b19a |
130721c
to
86707bc
Compare
Master branch: e63a023 |
86707bc
to
411f203
Compare
Master branch: 5e22dd1 |
We noticed our tc ebpf tools can't start after we upgrade our in-house kernel version from 4.19 to 5.10. That is because of the behaviour change in bpffs caused by commit d2935de ("vfs: Convert bpf to use the new mount API"). In our tc ebpf tools, we do strict environment check. If the enrioment is not match, we won't allow to start the ebpf progs. One of the check is whether bpffs is properly mounted. The mount information of bpffs in kernel-4.19 and kernel-5.10 are as follows, - kenrel 4.19 $ mount -t bpf bpffs /sys/fs/bpf $ mount -t bpf bpffs on /sys/fs/bpf type bpf (rw,relatime) - kernel 5.10 $ mount -t bpf bpffs /sys/fs/bpf $ mount -t bpf none on /sys/fs/bpf type bpf (rw,relatime) The device name in kernel-5.10 is displayed as none instead of bpffs, then our environment check fails. Currently we modify the tools to adopt to the kernel behaviour change, but I think we'd better change the kernel code to keep the behavior consistent. After this change, the mount information will be displayed the same with the behavior in kernel-4.19, for example, $ mount -t bpf bpffs /sys/fs/bpf $ mount -t bpf bpffs on /sys/fs/bpf type bpf (rw,relatime) Fixes: d2935de ("vfs: Convert bpf to use the new mount API") Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Cc: David Howells <dhowells@redhat.com>
411f203
to
219d609
Compare
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=601389 expired. Closing PR. |
Pull request for series with
subject: bpf: allow setting mount device for bpffs
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=601389